Fix package name for main activity when appId set #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamsmith
requested review from
Esemesek,
grabbou and
thymikee
as code owners
|
Lint is failing, can you run |
thymikee
approved these changes
Aug 10, 2020
|
@thymikee - is there anything I need to do to get this merged? First time contributor to this repo so just checking. |
|
Sorry to be that guy but can I get an ETA to merge this please? It's blocking some other OSS updates going out that will fix some issues for others. |
|
@grabbou please make sure to prioritize this on your ramp up today, it would be lovely to have it in and released today/tomorrow :) |
|
@grahamsmith sorry for our slow response here, we were occupied with lots of extra activities recently, including organizing and preparing for React Native EU (which starts in few minutes!! stream here: https://www.youtube.com/watch?v=DduUntL2Sv4). Hopefully we'll regain some time to get back to CLI maintenance :). I also hope we didn't discouraged you from future contributions 😊 |
|
@grahamsmith this is now released in v4.13, thank you! |
|
Amazing news. Thanks for sorting that out. |
thymikee
added a commit
that referenced
this pull request
Sep 17, 2020
* origin/master: (81 commits) chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (#1267) v4.13.0 chore: remove await in getLatestFile function call from downloadProfile file. (#1266) Augment react-native info with out of tree platform packages info (#1264) feat: add a command to download the Hermes Sampling Profiler to a local machine (#1246) chore(deps): bump lodash from 4.17.15 to 4.17.19 (#1221) Fix package name for main activity when appId set (#1242) Just use the users default browser (#1257) feat: improve progress indicator for iOS builds without xcpretty (#1254) fix: 🐛 executableFolderPath to run app name in iOS 14.0 (#1236) chore(deps): bump elliptic from 6.5.2 to 6.5.3 (#1233) v4.12.0 Add Windows info to react-native info (#1227) add new version RN Podfile link, autolinking docs. (#1245) docs: add linkage instructions for `yarn` v2 (#1237) v4.11.0 fix: adjust range on react-native peer dep to support 0.63 (#1234) chore: update jest config (#1241) Use new chrome based edge if the user is already running it, and not running chrome (#1222) Add windows logic to guess the users preferred editor for launchEditor (#1216) ...
thymikee
added a commit
to imoans/cli
that referenced
this pull request
Sep 17, 2020
* origin/master: (47 commits) chore(breaking): use Node 10 as compile target (react-native-community#1072) chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (react-native-community#1267) v4.13.0 chore: remove await in getLatestFile function call from downloadProfile file. (react-native-community#1266) Augment react-native info with out of tree platform packages info (react-native-community#1264) feat: add a command to download the Hermes Sampling Profiler to a local machine (react-native-community#1246) chore(deps): bump lodash from 4.17.15 to 4.17.19 (react-native-community#1221) Fix package name for main activity when appId set (react-native-community#1242) Just use the users default browser (react-native-community#1257) feat: improve progress indicator for iOS builds without xcpretty (react-native-community#1254) fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native-community#1236) chore(deps): bump elliptic from 6.5.2 to 6.5.3 (react-native-community#1233) v4.12.0 Add Windows info to react-native info (react-native-community#1227) add new version RN Podfile link, autolinking docs. (react-native-community#1245) docs: add linkage instructions for `yarn` v2 (react-native-community#1237) v4.11.0 fix: adjust range on react-native peer dep to support 0.63 (react-native-community#1234) chore: update jest config (react-native-community#1241) Use new chrome based edge if the user is already running it, and not running chrome (react-native-community#1222) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Working on a white label feature for an app, I ran into an issue where I needed to set the appId differently to the package name and an explicit main activity in a different package.
For example my build.gradle application ID could be
com.testand the manifest package becom.testhowever my main activity, from a dependency, has been set explicitly set in the manifest ascom.dependency.AnActivity.When running:
react-native run-android --appId com.test --main-activity com.dependency.AnActivitythe result would be:
Error: Activity class {com.test/com.packagename.com.dependency.AnActivity} does not exist.I have made a small change to allow an explicit main activity with package name set.
Test Plan:
Run similar to
react-native run-android --appId com.test --main-activity com.dependency.AnActivityand expect the explicit activity to start.Run
react-native run-android --appId com.test --main-activity AnActivityand expect the detected package name to be the prefix of the specified activity.