[android] Add support for autolinking via CMake #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2022
thymikee
reviewed
Jun 28, 2022
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jun 28, 2022
…34082) Summary: This is the companion PR of react-native-community/cli#1630 It extends the `ReactNative-application.cmake` file with instructions to pickup the autolinked libraries. ## Changelog [Internal] [Changed] - Extend the RN Application.cmake file to support Android autolinking Pull Request resolved: #34082 Test Plan: Tested locally as we don't have a way to test autolinking on CI. Reviewed By: cipolleschi Differential Revision: D37463203 Pulled By: cortinico fbshipit-source-id: 0b28e7f214c265ebfec4ccc59ae321f682299cf8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for autolinking via CMake. Similarly to #1603 it creates a
CMakeLists.txtalongside theAndroid.mkwith a similar logic. I will take care of adapting the template on RN's side to work with this.Test Plan:
Tested locally. Not sure how to test this e2e on CI.