feat: added last booted simulator pick & iPhone 14 as fallback + doc typos #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavikdenis
requested review from
grabbou,
thymikee and
Esemesek
as code owners
adamTrz
approved these changes
Sep 26, 2022
| @@ -32,19 +32,19 @@ npx react-native@${VERSION} init ProjectName | |||
|
|
|||
| #### Initializing project with custom template | |||
|
|
|||
| It is possible to initialise a new application with a custom template with | |||
| It is possible to initialize a new application with a custom template with | |||
|
That's definitely an improvement, thanks! One thing I'd add as a followup, is to select the first available simulator if none of the fallbacks exist and a user never opened a simulator—which will happen for first-time users next year when starting with fresh Xcode 15 I suppose :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
After a new Xcode install, when the simulators are fresh, and CLI yet doesn't have the latest iPhone listed as a fallback simulator, CLI fails to pick an appropriate simulator. If the user however run already any preferred simulator, it gets picked instead of failing on picking the appropriate simulator.