-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Buck from Jitpack #178
Conversation
@gengjiawen it seems like build is "skipped" due to:
Have you ever experienced something similar? |
Yeap: My case is running test case. |
Awesome will try this 👍 Thanks for the suggestion |
Nope no luck. Also unsure why this is the case 🤔 as we should be using less spaces with my changes. |
Yeap. Looks like a upstream bug or new limitation from github action for me. |
Another worth try is revert cmdlines https://github.com/react-native-community/docker-android/pull/175/files. It's the only related change. (It works on circleCI) |
i thought about maximising build space at first too after mini freakout suddenly all PR's failing 😆 but knew had to be smth bigger thx @gengjiawen again for cross-referencing and code review 22.04 fixed it for me, so now rebasing/re-trying all PR's w renovate (should hopefully be passing again as usual in couple/few hrs) |
e50b54c
to
5d2284a
Compare
114d322
to
39be52e
Compare
8e0b9e9
to
5439ac8
Compare
5439ac8
to
8b421ff
Compare
@gengjiawen I had to move the build step to CircleCI as the Github Runner was too much constrained. Now all is green. Are we fine merging this? |
Yeap. |
I'm updating the Buck version + switching to use the version from Jitpack:
https://jitpack.io/#facebook/buck/v2022.05.05.01
I've realized we hava a
-java11.pex
file we can use and should work fine with Java11 so there is no need to build Buck from source anymore.