Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the Docker Image #199

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Cleanup the Docker Image #199

merged 2 commits into from
Apr 18, 2023

Conversation

cortinico
Copy link
Member

This cleans up our Docker Image by removing:

  • Buck executable
  • Emulator dependencies (we're not currently using them)
  • Fallback ANDROID_BUILD_VERSION
  • Fallback CMAKE_VERSION

@gengjiawen
Copy link
Member

This needs to be a major version.

@cortinico
Copy link
Member Author

Yup I'll make 8.0 out of this

@cortinico cortinico merged commit 0af6aa5 into master Apr 18, 2023
@cortinico cortinico deleted the nc/image-cleanup branch April 18, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cortinico @gengjiawen