Bump node from 16 to 18 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently blocked on CI as we need to bump the JDK version of React Native to 17 for CI to be green. |
|
@arushikesarwani94 could you try to rebase on top of: That should unblock you for now |
|
Will rebase post #203 is landed in master. |
cortinico
approved these changes
Jun 16, 2023
arushikesarwani94
force-pushed
the
node_bump
branch
from
fa9c566
to
5588038
Compare
gengjiawen
approved these changes
Jun 17, 2023
|
Thx for the contributions :) |
|
Should we release this as 9.0 ? @gengjiawen |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 17, 2023
Summary: Post bumping the node version in react-native-community/docker-android#202 updating the container version in RN Differential Revision: D46819521 fbshipit-source-id: 2bff1306c41535b56d0ac4e928548b9e055a701e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are bumping node version in React Native from 16 to 18 in : facebook/react-native#37709
Updating the Docker Image of Android as well to fix the Circle CI.