Skip to content

Commit

Permalink
Fix projects being broken on dependencies starting with a.. (#41621)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook/react-native#41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes #41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79

Original-Commit: facebook/react-native@5ec2c01
  • Loading branch information
cortinico authored and facebook-github-bot committed Nov 23, 2023
1 parent 5d11cf7 commit 8570eca
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions template/android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
ext {
buildToolsVersion = "34.0.0"
Expand All @@ -19,3 +17,5 @@ buildscript {
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin")
}
}

apply plugin: "com.facebook.react.rootproject"

0 comments on commit 8570eca

Please sign in to comment.