Fixed onMapReady no longer getting called on iOS

[IjzerenHein]

Hi, this fixes onMapReady no longer getting called correctly in v0.18.x.

Due to this commit (https://github.com/airbnb/react-native-maps/pull/1797/files#diff-8a72baa08460d22c71989ddcbf76d49f), onMapReady was only called when the very first MapView was rendered for the very first time. After unmounting/mounting, or rendering any other MapView, onMapReady would be never called.

[rborn]

LGTM
@alvelig should I merge, or you do it ? That's a question for all the PRs I can review 😊

[rborn]

@christopherdro ?

[vendramini]

I'm using the latest version and onMapReady still not being called. Is this PR released?

Thanks!

[emilefleming]

Same here, running 0.19.0 with Google Maps on iOS and it only fires on the first map load. InitialRegion is working now party but doesn't seem to respect the delta and is very zoomed out. @vendramini are you seeing that as well?

[alvelig]

@vendramini are you using GoogleMaps iOS? No, this PR not released yet. Please try npm i -S git+ssh://git@github.com:react-community/react-native-maps.git

@emilefleming Could you please open an issue for that? As this PR does not touch GoogleMaps

[emilefleming]

@alvelig sure thing.

[vendramini]

@alvelig no, I'm using apple maps.
@emilefleming no, didn't happens here.

EDIT
@alvelig it's working now pointing to react-native-maps.git. Is safe to point package directly to master? Should I change when this PR is released or doesn't matter?

Thanks.

[alvelig]

@vendramini Sure, with npm you just get the same but through npm and released under some tag (version). Of course, it's better to keep npm version in package.json, because it gives you version control (exact version, not higher than, etc).

[ghost]

@IjzerenHein @alvelig this doesn't seem to work in the latest release? I still experience the following; I removed cache, rebuilt etc.

onMapReady was only called when the very first MapView was rendered for the very first time. After unmounting/mounting, or rendering any other MapView, onMapReady would be never called.

[IjzerenHein]

Seems this hasn't been released yet to npm, you should use the master branch from github until that is done

[rborn]

@christopherdro do we need to push a new version to npm ? thnx cc: @alvelig