Fixed pointForCoordinate/coordinateForPoint Promises in iOS (#2039, #2061)

[danielgindi]

Does any other open PR do the same thing?

No

What issue is this PR fixing?

Changes to these functions that did not reflect in both providers. Currently the API is broken - expecting callback in GoogleMaps and returning Promise in Air. While the docs says it returns Promise.

How did you test this PR?

Written simple code with await to print results of both functions, in Air and Google provider.

[rborn]

@alvelig 🐽

[lachenmayer]

Hey there, I was actually looking at this same issue too before the holidays.
I spent a considerable amount of effort trying to get an integration test running using RCTTest.
The code for that is here: master...lachenmayer:pointforcoordinate-bug
The main difference is a new AirMapsExplorerTest target which uses RCTTestRunner to run tests. These can be run in Xcode by pressing ⌘-U in the workspace (while the packager is running).

Currently, the only test is for exactly this issue: https://github.com/lachenmayer/react-native-maps/blob/pointforcoordinate-bug/example/tests/PointForCoordinate.js
I'm going to try apply this patch & see if it passes (it should!).

In general, I was wondering if there is any interest in adding these kinds of tests - I feel like we could avoid a lot of these kinds of issues with a test suite which works very similarly to how React Native itself is tested.
If you agree, I'll make a PR with a cleaned up version of this & add some instructions on how to add new test cases.
Cheers :)

[alvelig]

LGTM

@lachenmayer I was thinking about tests too, but did not know the best way. Let's try to add example tests for this, so we can ask contributors to make tests for their PRs.

[lachenmayer]

@alvelig please check out #2161 for a test for this PR :)

[davija]

Any updates on this? It has been almost a month since there was any traffic on this and this is currently a blocking issue for me.