-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed google play dependency from 9.8.0 to point to latest version #877
changed google play dependency from 9.8.0 to point to latest version #877
Conversation
This fixes an issue I was having as well, see here: #894 |
please merge this one! |
I'm against such a change. |
My react-native-app was crashing without any error. This was happening only for android, it was working for ios. How did I find out the reason for the crash? react-native: 0.39.2 |
@kiranraj2k This solution does work, but here is where it might fail and be hard to find: Consider that you have google-services v. 10.0.1 and your friend has google-services v. 9.8.0. If something works with you on 10.0.1 it might not work on 9.8.0, and since this solution just uses the latest version installed, it will be really hard to find out the reason if anything like this happens (you saw how ambiguous the error is with such things). This is really important if you have a bot that is responsible of automatically building the app and publishing it for alpha testing, especially since these will not check for newer versions of play-services if you're using the '+' for performance reasons and will just use the installed one if available. If you want to use a version other than the one included with the react-native-maps, you can override it in your gradle build (see #910 for how to do that) |
@akshay2604: thanks you for opening this PR, had the exact same issue! |
thanks for this PR. had also n issue related to this. Where if you add any play services dependency. Maps would make my app not start. |
Thanks! this worked for me as well.. we upgraded from 0.39 to 0.41 was getting the same error and made the change.. we are good to go! |
This is breaking builds again, is there a reason why you don't simply use '+' for the gms deps? |
I upgraded react native maps and app was crashing on android redmi 3s prime. I changed google play base and maps dependency to '+' and it worked. Also it fixes #831 and #874