Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed google play dependency from 9.8.0 to point to latest version #877

Conversation

akshay2604
Copy link

I upgraded react native maps and app was crashing on android redmi 3s prime. I changed google play base and maps dependency to '+' and it worked. Also it fixes #831 and #874

@bfarrgaynor
Copy link

This fixes an issue I was having as well, see here: #894

@jpgarcia
Copy link

please merge this one!

@alialamine
Copy link
Contributor

alialamine commented Dec 20, 2016

I'm against such a change.
Having a precise version is really important for cd and ci because we need the stability and predicatbility that come with specifying a version. Having such a change like this will create a layer of abstraction that will be a nightmare to debug if anything goes wrong on the ci server and not on the dev machine. This is especially true if the person is just beginning using the library and doesn't notice this thing. See my solution on #910 that can solve this issue, and still have a specific version.

@kiranraj2k
Copy link

kiranraj2k commented Dec 26, 2016

My react-native-app was crashing without any error. This was happening only for android, it was working for ios. How did I find out the reason for the crash?
I made use of 'adb logcat' to find out what was going on. That is when I saw some fatal exceptions related to this library. This is my first time using this package.
@akshay2604 solution worked for me too! I normally look for common errors in the issues section.
Fortunately I had a look at the pull requests.
I believe this solution should be at least included in the troubleshooting section, if not integrated in to the package.

react-native: 0.39.2
androidOS: 5.1
react-native-maps: 0.12.2

@alialamine
Copy link
Contributor

@kiranraj2k This solution does work, but here is where it might fail and be hard to find:

Consider that you have google-services v. 10.0.1 and your friend has google-services v. 9.8.0. If something works with you on 10.0.1 it might not work on 9.8.0, and since this solution just uses the latest version installed, it will be really hard to find out the reason if anything like this happens (you saw how ambiguous the error is with such things).

This is really important if you have a bot that is responsible of automatically building the app and publishing it for alpha testing, especially since these will not check for newer versions of play-services if you're using the '+' for performance reasons and will just use the installed one if available.

If you want to use a version other than the one included with the react-native-maps, you can override it in your gradle build (see #910 for how to do that)

@akshay2604 akshay2604 closed this Dec 26, 2016
@lucasbento
Copy link
Contributor

@akshay2604: thanks you for opening this PR, had the exact same issue!

@alvarolorentedev
Copy link
Contributor

thanks for this PR. had also n issue related to this. Where if you add any play services dependency. Maps would make my app not start.
My 2 cents on why the why i prefer not force a specific version is because normally this module is not the only one added and if each starts requesting different random versions of play services it might get more difficult to debug (also normally new versions should be backwards compatible).
Also for what @alialamine said, i think its sensible concern, and should be added as a note in the README or documentation as the recommended version and help to troubleshoot.

@sandman45
Copy link

Thanks! this worked for me as well.. we upgraded from 0.39 to 0.41 was getting the same error and made the change.. we are good to go!

@anthonyhumphreys
Copy link

This is breaking builds again, is there a reason why you don't simply use '+' for the gms deps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with react-native-push-notification
9 participants