-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite #30
Merged
Merged
Rewrite #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e contenarized themes.
Releases: nextjs-themes@3.1.3 app-router@0.0.23 pages-router@1.0.18 simple-multi-theme@1.0.18 tailwind@0.1.12 vite-example@0.0.23
- Will use script injection
- Ensuring no breaking changes. Kept here only to ensure that existing app do not start throwing errors.
…y to access the store while injecting the scripts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 406 486 +80
Branches 77 64 -13
=========================================
+ Hits 406 486 +80 ☔ View full report in Codecov by Sentry. |
…ayank Kumar Chaudhari</a> [skip ci]
- Will introduce later with proper express config to serve react app.
Releases: nextjs-themes@4.0.0 @repo/shared@0.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite…
We have ensured