Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssr optimization #21

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Ssr optimization #21

merged 11 commits into from
Nov 30, 2023

Conversation

mayank1513
Copy link
Member

For server side syncing, we need to use cookies and headers. This means that this component and its children can not be static. They will be rendered server side for each request. Thus, we are avoiding the wrapper.

We are rebranding ServerSideWrapper for Next.js as NextJsSSRThemeSwitcher. Now, only the NextJsSSRThemeSwitcher will be rendered server side for each request and rest of your app can be server statically.

@mayank1513 mayank1513 self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e9919b) 100.00% compared to head (3037ef3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          253       270   +17     
  Branches        55        54    -1     
=========================================
+ Hits           253       270   +17     
Flag Coverage Δ
fork-me 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayank1513 mayank1513 merged commit a9c93ff into main Nov 30, 2023
3 checks passed
@mayank1513 mayank1513 deleted the ssr-optimization branch November 30, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant