Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-duplicate styled-components package #542

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

willopez
Copy link
Member

Resolves #503
Impact: minor
Type: bugfix

Issue

The styled-components package was being loaded twice.

Solution

Add a resolve alias to the WebPack config to import only the es modules version of styled-components

Testing

  1. Start storefront
  2. Inspect browser console, and verify there is no error regarding duplicate styled-components

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez requested a review from aldeed June 27, 2019 00:19
@willopez willopez self-assigned this Jun 27, 2019
@willopez willopez added the bug For issues that describe a defect or regression in the released software label Jun 27, 2019
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed warning is gone

@aldeed aldeed merged commit 66e09b9 into develop Jun 28, 2019
@aldeed aldeed deleted the willopez-dedup-styled-components branch June 28, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StyledComponents Error: Trying to insert a new style tag, but the given Node is unmounted!
2 participants