Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special characters in variables #639

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

rosshadden
Copy link
Contributor

Resolves #638
Impact: minor
Type: bugfix

Issue

The bin/setup script doesn't handle special characters. Noticed examples are $ and &.

Solution

Used command instead of eval. There are a lot of reasons for this, and eval is generally frowned-upon. One such reason is it breaks when given "dirty" data.

Breaking changes

I don't think there are any breaking changes with this.

Testing

Run bin/setup and make sure everything is working as expected. I don't have an exhaustive list of what all that may be.

…l characters

Signed-off-by: Ross Hadden <rosshadden@gmail.com>
@rosshadden rosshadden changed the base branch from develop to release-v3.0.0 December 31, 2019 22:49
@aldeed aldeed merged commit 88746fe into release-v3.0.0 Jan 2, 2020
@aldeed aldeed deleted the fix-special-characters-in-variables branch January 2, 2020 17:44
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants