fix: docker production build

[mikemurray]

Resolves #691
Impact: critical
Type: bugfix|chore

Issue

Docker production builds are failing

Solution

• Remove the quotes and ignore the lint issue in the DoclerFile
• Adjust some code related to page optimization so the build doesn't fail if the next app isn't connected to the API

Breaking changes

none

Testing

1. Run the app locally and verify the product and tags pages still work
2. Test the docker build

docker build --network=host -t reactioncommerce/example-storefront:3.1.0

3. Run with

docker run -it --name storefront2 -p 4000:4000 --env-file .env.prod --network reaction.localhost reactioncommerce/example-storefront:3.1.0

[mikemurray]

@janus-reith With the code commented out the docker build is getting further, but it's encountering issues when optimizing pages. The API is not running on CI so this is causing the build to fail. Do you know have any ideas on how to solve this?

error-fetching-graphql FetchError: request to http://localhost:3000/graphql failed, reason: connect ECONNREFUSED 127.0.0.1:3000
 
    at ClientRequest.<anonymous> (/usr/local/src/app/node_modules/next/dist/compiled/node-fetch/index.js:1:147710)
 
    at ClientRequest.emit (events.js:315:20)
 
    at Socket.socketErrorListener (_http_client.js:426:9)
 
    at Socket.emit (events.js:315:20)
 
    at emitErrorNT (internal/streams/destroy.js:92:8)
 
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
 
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
 
  type: 'system',
 
  errno: 'ECONNREFUSED',
 
  code: 'ECONNREFUSED'
 
}

[janus-reith]

@mikemurray This seems to indicate that no GraphQL API is available at that url, which is expected when running in your CI.
localhost:3000 would only be available on the same machine (with docker host network access).
You need to point BUILD_GRAPHQL_URL to a running API.
I noted some of my considerations here: #667 (comment)