Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Make resolutions cleaner for possible pnp usage #3330

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Dec 24, 2024

Add rollup local package to share configurations. Prep for pnp by adding explicit packages to devdeps, and only using yarn.

Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: b169bf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ntucker ntucker force-pushed the pnp branch 21 times, most recently from c33dd81 to e71d49c Compare December 26, 2024 13:14
@ntucker ntucker force-pushed the pnp branch 4 times, most recently from 8d96361 to 58a25a7 Compare December 28, 2024 11:59
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (19d4669) to head (6bcbc0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3330   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         132      132           
  Lines        2274     2274           
  Branches      466      466           
=======================================
  Hits         2248     2248           
  Misses         13       13           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker changed the title internal: Use yarn pnp internal: Make resolutions cleaner for possible pnp usage Dec 28, 2024
@ntucker ntucker marked this pull request as ready for review December 28, 2024 18:40
@ntucker ntucker merged commit 1112651 into master Dec 28, 2024
22 checks passed
@ntucker ntucker deleted the pnp branch December 28, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant