Skip to content

Commit

Permalink
fix: uno winui csproj incorrectly configured (#2989)
Browse files Browse the repository at this point in the history
* fix: uno winui csproj incorrectly configured

* Update ReactiveUI.Uno.WinUI.csproj

* Fix

* Update ReactiveUI.Uno.WinUI.csproj

* Add back msbuild sdk extras

* Further fixes
  • Loading branch information
glennawatson authored Oct 31, 2021
1 parent 4ff7d6c commit 0ac954a
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 13 deletions.
49 changes: 37 additions & 12 deletions src/ReactiveUI.Uno.WinUI/ReactiveUI.Uno.WinUI.csproj
Original file line number Diff line number Diff line change
@@ -1,19 +1,44 @@
<Project>

<Project Sdk="MSBuild.Sdk.Extras">
<PropertyGroup>
<DefineConstants>$(DefineConstants);HAS_WINUI</DefineConstants>
<TargetFrameworks>netstandard20;MonoAndroid11.0;Xamarin.iOS10;Xamarin.Mac20;net6.0-android;net6.0-ios;net6.0-macos</TargetFrameworks>
<PackageId>ReactiveUI.Uno.WinUI</PackageId>
<PackageDescription>Contains the ReactiveUI platform specific extensions for Uno WinUI</PackageDescription>
<DefineConstants>$(DefineConstants);HAS_UNO;HAS_WINUI</DefineConstants>
<NoWarn>$(NoWarn);SA1648;CA1816;CA1001;CS0108;CS0114;CS3021;CS1574;CA1303</NoWarn>
<Nullable>enable</Nullable>
<LangVersion>preview</LangVersion>
<PackageTags>mvvm;reactiveui;rx;reactive extensions;observable;LINQ;events;frp;net;unoplatform;winui</PackageTags>
</PropertyGroup>

<Import Project="..\ReactiveUI.Uno\ReactiveUI.Uno.csproj" />

<PropertyGroup>
<!-- Remove uap target -->
<TargetFrameworks>netstandard20;MonoAndroid11.0;Xamarin.iOS10;Xamarin.Mac20;net6.0-android;net6.0-ios;net6.0-macos</TargetFrameworks>
<PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard')) ">
<DefineConstants>$(DefineConstants);WASM</DefineConstants>
</PropertyGroup>


<ItemGroup>
<EmbeddedResource Remove="Resources\**" />
<None Remove="Resources\**" />
<Compile Remove="Resources\**" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Uno.WinUI" Version="3.10.11" />
</ItemGroup>

<ItemGroup Condition=" $(TargetFramework.StartsWith('netstandard')) ">
<PackageReference Include="Reactive.Wasm" Version="1.*" />
</ItemGroup>

<ItemGroup>
<PackageReference Remove="Uno.UI" />
<PackageReference Include="Uno.WinUI" Version="3.9.7" />
<Compile Include="..\ReactiveUI.Uwp\TransitioningContentControl.Empty.cs" LinkBase="ReactiveUI.Uwp" />
<Compile Include="..\ReactiveUI.Uwp\DependencyObjectObservableForProperty.cs" LinkBase="ReactiveUI.Uwp" />
<Compile Include="..\ReactiveUI.Uwp\common\**\*.cs" LinkBase="common" />
<Compile Include="..\ReactiveUI.Uno\*.cs" LinkBase="ReactiveUI.Uno" />

<None Include="..\ReactiveUI.Uwp\ReactiveUI.rd.xml" PackagePath="lib\uap\ReactiveUI\Properties\ReactiveUI.rd.xml" Pack="true" />
</ItemGroup>


<ItemGroup>
<ProjectReference Include="..\ReactiveUI\ReactiveUI.csproj" />
</ItemGroup>

</Project>
5 changes: 5 additions & 0 deletions src/ReactiveUI.Uno/ActivationForViewFetcher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@
using System.Reactive.Linq;
using System.Reflection;

#if HAS_UNO_WINUI
using Microsoft.UI.Xaml;
using Windows.Foundation;
#else
using Windows.Foundation;
using Windows.UI.Xaml;
#endif

namespace ReactiveUI.Uno
{
Expand Down
5 changes: 5 additions & 0 deletions src/ReactiveUI.Uno/CoreDispatcherScheduler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@
using System.Runtime.ExceptionServices;
using System.Threading;

#if HAS_UNO_WINUI
using Microsoft.UI.Xaml;
using Windows.UI.Core;
#else
using Windows.UI.Core;
using Windows.UI.Xaml;
#endif

namespace System.Reactive.Concurrency
{
Expand Down
2 changes: 1 addition & 1 deletion src/ReactiveUI.Uno/ReactiveUI.Uno.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</ItemGroup>

<ItemGroup Condition=" !$(TargetFramework.StartsWith('uap')) ">
<PackageReference Include="Uno.UI" Version="3.9.7" />
<PackageReference Include="Uno.UI" Version="3.10.11" />
</ItemGroup>

<ItemGroup Condition=" $(TargetFramework.StartsWith('netstandard')) ">
Expand Down

0 comments on commit 0ac954a

Please sign in to comment.