[BUG] In Splat/Splat.csproj, TFM in Itemgroup's Condition seems to be unreachable compared to TFM in TargetFrameworks

[eriawan]

Describe the bug
In https://github.com/reactiveui/splat/src/Splat/Splat.csproj, TFM in Itemgroup's Condition seems to be unreachable compared to TFM defined in TargetFrameworks.

Steps To Reproduce
In the code of Splat.csproj, the TFMs defined in TargetFrameworks doesn't specify TFM starts with net46 whereas in the ItemGroup's condition below specify condition to check TFM that starts with net46:

https://github.com/reactiveui/splat/blob/main/src/Splat/Splat.csproj#L3-L15

    <TargetFrameworks>netstandard2.0;net5.0;net6.0</TargetFrameworks>
    <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net461;net472</TargetFrameworks>
    <AssemblyName>Splat</AssemblyName>
    <RootNamespace>Splat</RootNamespace>
    <Authors>.NET Foundation and Contributors</Authors>
    <Description>A library to make things cross-platform that should be</Description>
    <PackageId>Splat</PackageId>
    <NoWarn>$(NoWarn);1591</NoWarn>
    <LangVersion>latest</LangVersion>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup Condition=" $(TargetFramework.StartsWith('net46')) ">

NOTE:
Step to reproduce I think it's not necessary for this. CMIIW.

Expected behavior
If any TFM starts with net46 is going to be used, then we should add net46, net461 to the TargetFrameworks, otherwise we should use netstandard2.0 as the TFM in the condition of the ItemGroup.
As far as I know, checking for TFM starts with net46 is not necessary, because

Screenshots
If applicable, add screenshots to help explain your problem.

Environment(please complete the following information):
N/A

Additional context
This bug report is focusing on more correctness and the TFM defined in the condition should match the TargetFrameworks defined.

[eriawan]

if this issue is considered as a bug, I would love to submit PR 🙂

[glennawatson]

Not a bug but thanks for reporting. StartsWith is used to allow for easier upgrading of the target framework.

[glennawatson]

Reopening to discuss further. May be an issue with that file after discussing offline.

[eriawan]

@glennawatson
thanks!

[glennawatson]

I suspect the net framework targets aren't needed in the main splat.csproj since all that was moved to the Splat.Drawing project. Happy to have a PR to remove net461/net472 and removing the conditional.

[eriawan]

ok, I'm going to submit PR in about one hour.

[eriawan]

PR submitted: #788

[eriawan]

@glennawatson

About this:

Happy to have a PR to remove net461/net472 and removing the conditional.

Do you also want to remove unnecessary net461 / net472 usage and conditional too? Currently I focus on Splat.csproj first :)

[eriawan]

@glennawatson

I understand now! Many thanks for the pointer to that net46;net472 ! 👍
I'm updating my PR now.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.