Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update groups #1041

Merged
merged 1 commit into from
Aug 11, 2023
Merged

housekeeping: Update groups #1041

merged 1 commit into from
Aug 11, 2023

Conversation

glennawatson
Copy link
Contributor

Groups are currently under the github-actions portion of the supported ecosystem. Move to nuget.

Cleanup old stuff

Groups are currently under the github-actions portion of the supported ecosystem. Move to nuget.

Cleanup old stuff
@glennawatson glennawatson requested a review from dpvreony August 11, 2023 04:48
@glennawatson
Copy link
Contributor Author

Hey @dpvreony there was a little bug with your previous implementation, all the groups were under the github actions ecosystem. Corrected.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.43% 🎉

Comparison is base (bb52255) 74.92% compared to head (90d20da) 75.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   74.92%   75.35%   +0.43%     
==========================================
  Files          93       93              
  Lines        4387     4387              
==========================================
+ Hits         3287     3306      +19     
+ Misses       1100     1081      -19     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpvreony dpvreony merged commit 4215a10 into main Aug 11, 2023
@dpvreony dpvreony deleted the glennawatson-patch-1 branch August 11, 2023 08:04
@dpvreony
Copy link
Member

thanks, will raise a pr in reactiveui now it's working correctly

@glennawatson
Copy link
Contributor Author

Guess with rxui Maui and xamarin likely should be similar groups.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants