Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for API tests, Simplify Targets #1066

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix for API tests, Simplify Targets #1066

merged 1 commit into from
Nov 20, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix for API tests

What is the current behavior?

API tests do not fail

What is the new behavior?

API tests now fail if change is recognised
Simplified targets into mostly a single location for updates

What might this PR break?

Non expected, but part of a breaking change overall

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f63a155) 74.06% compared to head (a6697e2) 69.79%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Splat/ServiceLocation/InternalLocator.cs 10.00% 9 Missing ⚠️
src/Splat/TargetFrameworkExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   74.06%   69.79%   -4.28%     
==========================================
  Files          95       95              
  Lines        5530     4609     -921     
  Branches      632      633       +1     
==========================================
- Hits         4096     3217     -879     
+ Misses       1230     1186      -44     
- Partials      204      206       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 3da790b into main Nov 20, 2023
1 of 3 checks passed
@ChrisPulman ChrisPulman deleted the CP_FixForAPIChecks branch November 20, 2023 00:15
Copy link

github-actions bot commented Dec 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants