Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: initial replace fxcop with net analyzers #649

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

dpvreony
Copy link
Member

What kind of change does this PR introduce?

Replaces FxCop with Net Analyzers to reduce the build warning spam
closes #648

What might this PR break?

need to assess build output is like for like and adequate

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #649 (33687ed) into main (2f7b3a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   69.92%   69.92%           
=======================================
  Files          98       98           
  Lines        4569     4569           
=======================================
  Hits         3195     3195           
  Misses       1374     1374           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7b3a3...33687ed. Read the comment docs.

@glennawatson glennawatson merged commit df32c9e into main Dec 15, 2020
@glennawatson glennawatson deleted the netanalyzers branch December 15, 2020 21:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

housekeeping: fxcop deprecation build warning spam
2 participants