fix for SplatColor Equal and tests for SplatColor #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplatColor == was looking at how the SplatColor was generated to compare if equal Now using ARGB comparision and if all are equal its equal. Added KnownName lookup for ARGB which will automatically convert to a KnownName generated Color if it is a match to a KnownColor.
Codecov Report
@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 71.77% 73.31% +1.54%
==========================================
Files 101 98 -3
Lines 4843 4835 -8
==========================================
+ Hits 3476 3545 +69
+ Misses 1367 1290 -77
Continue to review full report at Codecov.
|
glennawatson
approved these changes
Jul 25, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
feature
tests
What is the current behaviour?
SplatColor == was looking at how the SplatColor was generated to compare if equal
SplatColor != was just comparing two instances directly
What is the new behaviour?
Now using ARGB comparision and if all are the same its equal.
the inverse of == is used for !=.
Added KnownName lookup for ARGB which will automatically convert to a KnownName generated Color if it is a match to a KnownColor.
What might this PR break?
if user was checking equal and relying on the way it was generated for comparison to be true this will no longer be true.
Please check if the PR fulfils these requirements
Other information:
added a KnownColor of Empty