Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmark tests #736

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Update Benchmark tests #736

merged 2 commits into from
Aug 2, 2021

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update

What is the current behaviour?

benchmark is not setup for current project status

What is the new behaviour?

updated setup

What might this PR break?

N/A

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #736 (730d68b) into main (5a3df5b) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   74.22%   74.12%   -0.11%     
==========================================
  Files          99       99              
  Lines        4967     4967              
==========================================
- Hits         3687     3682       -5     
- Misses       1280     1285       +5     
Impacted Files Coverage Δ
...ceMonitoring/DefaultFeatureUsageTrackingSession.cs 92.00% <0.00%> (-4.00%) ⬇️
src/Splat/Logging/WrappingFullLogger.cs 64.28% <0.00%> (-1.30%) ⬇️
src/Splat/MemoizingMRUCache.cs 62.10% <0.00%> (-1.06%) ⬇️
src/Splat/Logging/FullLoggerExtensions.cs 32.38% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3df5b...730d68b. Read the comment docs.

@dpvreony dpvreony merged commit 7785d8f into main Aug 2, 2021
@dpvreony dpvreony deleted the update_Benchmark branch August 2, 2021 10:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants