Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping fix build stop Visual studio restarting #766

Merged
merged 6 commits into from
Sep 14, 2021

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update

What is the current behaviour?

build fails as Windows is trying to restart after Visual Studio install

What is the new behaviour?

using 2022 server with VS2022, updating and adding features and workloads as required

What might this PR break?

none

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman changed the title houekeeping fix build stop Visual studio restarting housekeeping fix build stop Visual studio restarting Sep 13, 2021
@ChrisPulman ChrisPulman enabled auto-merge (squash) September 13, 2021 20:14
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #766 (205047e) into main (60d8d83) will not change coverage.
The diff coverage is n/a.

❗ Current head 205047e differs from pull request most recent head f6818da. Consider uploading reports for the commit f6818da to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #766   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          99       99           
  Lines        4968     4968           
=======================================
  Hits         3712     3712           
  Misses       1256     1256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af60edf...f6818da. Read the comment docs.

@glennawatson glennawatson enabled auto-merge (squash) September 14, 2021 02:56
@glennawatson glennawatson merged commit d46f82b into main Sep 14, 2021
@glennawatson glennawatson deleted the fixBuildAndTests branch September 14, 2021 03:10
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants