Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Project targeting net5.0 won't build Splat.Drawing #810

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

fix for #809

What is the current behaviour?

Net5.0 and Net6.0 libraries have no targets

What is the new behaviour?

Added targets for Net5.0 and Net6.0 libraries

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Added targets for Net5.0 and Net6.0 libraries
@glennawatson
Copy link
Contributor

Need a better PR description, what is it you are fixing ;)

@glennawatson glennawatson changed the title fix for #809 fix for Project targeting net5.0 won't build Splat.Drawing Nov 3, 2021
@glennawatson glennawatson enabled auto-merge (squash) November 3, 2021 20:52
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #810 (84d2d72) into main (6b87b77) will not change coverage.
The diff coverage is n/a.

❗ Current head 84d2d72 differs from pull request most recent head 7dee7a8. Consider uploading reports for the commit 7dee7a8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage   74.36%   74.36%           
=======================================
  Files          99       99           
  Lines        4970     4970           
=======================================
  Hits         3696     3696           
  Misses       1274     1274           
Impacted Files Coverage Δ
.../Platforms/ServiceLocationDrawingInitialization.cs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b87b77...7dee7a8. Read the comment docs.

@glennawatson glennawatson merged commit faee510 into main Nov 3, 2021
@glennawatson glennawatson deleted the fix_809_AddNet5Net6TargetsToDrawing branch November 3, 2021 21:12
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Project targeting net5.0 won't build with Splat.Drawing installed
2 participants