fix(forkJoin): test for object literal #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8422
💛 - Coveralls |
benlesh
approved these changes
May 2, 2019
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this pull request
May 15, 2019
* test(forkJoin): add failing test for ReactiveX#4737 * fix(forkJoin): test for object literal not observable Closes ReactiveX#4737.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a problem with
forkJoin's inspection of its first argument to determine whether or not it should be joining the properties of an object literal.The current code checks to see if the argument is not an
Observableand if it isn't, it proceeds as if it has been called with an object literal. However. the argument could be anotherObservableInput- like aPromise.This PR adds a failing test and changes the check to compare the argument's prototype to
Object.prototype.Related issue (if exists): #4737