Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage: traduction au-dessus du fold #449

Merged
merged 1 commit into from
May 6, 2023
Merged

Homepage: traduction au-dessus du fold #449

merged 1 commit into from
May 6, 2023

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Apr 25, 2023

La core team nous demande de ne pas la traduire davantage pour le moment car ça risque de pas mal bouger (idem pour les layouts et la nav)

@tdd tdd self-assigned this Apr 25, 2023
@tdd tdd added the Reviewed label Apr 25, 2023
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.28 KB (🟡 +282 B) 169.9 KB
/500 76.27 KB (🟡 +282 B) 169.9 KB
/[[...markdownPath]] 77.7 KB (🟡 +282 B) 171.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd tdd requested a review from sheplu April 25, 2023 10:18
@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Reviewed labels Apr 25, 2023
@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Apr 26, 2023
@tdd tdd requested review from JeremiePat and Nab69 April 26, 2023 14:19
@tdd tdd added the translator:seasoned The author of that translation is a seasoned React docs translator label Apr 26, 2023
@tdd
Copy link
Collaborator Author

tdd commented Apr 28, 2023

Coucou @sheplu @Nab69 @JeremiePat ! L'un de vous pourrait-il consacrer un tout p'tit moment à me relire ça pour que je merge ? Merci mille fois !

@tdd tdd force-pushed the copy/homepage-atf branch from a696211 to 487afb4 Compare May 6, 2023 10:17
@tdd tdd merged commit c3b7db1 into main May 6, 2023
@tdd tdd deleted the copy/homepage-atf branch May 6, 2023 10:19
@github-actions
Copy link

github-actions bot commented May 6, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.57 KB (🟡 +210 B) 170.19 KB
/500 76.56 KB (🟡 +210 B) 170.19 KB
/[[...markdownPath]] 77.98 KB (🟡 +210 B) 171.61 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR translator:seasoned The author of that translation is a seasoned React docs translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant