Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling up with reducer and context #511

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

linsolas
Copy link
Contributor

@linsolas linsolas commented Jul 7, 2023

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @linsolas !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Écoute c'est super bravo, j'ai très peu de choses à dire.

Pour le choix câblage / plomberie, je te laisse faire l'arbitrage final si tu ne me rejoins pas (attention à bien être cohérent sur l'ensemble).

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner. J'y recalerai si besoin les usual suspects : espaces insécables avant les ponctuations doubles, et apostrophes françaises.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans main !

src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
src/content/learn/scaling-up-with-reducer-and-context.md Outdated Show resolved Hide resolved
@tdd tdd self-assigned this Jul 10, 2023
@tdd tdd added Reviewed scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator labels Jul 10, 2023
@tdd tdd force-pushed the scaling-up-with-reducer-and-context branch from 640ed03 to dc6067e Compare July 11, 2023 07:53
@tdd tdd merged commit a8b59bc into reactjs:main Jul 11, 2023
@linsolas linsolas deleted the scaling-up-with-reducer-and-context branch September 11, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants