Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add french translation for findDOMNode #582

Merged
merged 3 commits into from
Sep 7, 2023
Merged

add french translation for findDOMNode #582

merged 3 commits into from
Sep 7, 2023

Conversation

emmadal
Copy link
Contributor

@emmadal emmadal commented Sep 6, 2023

Here you will find the french translation of findDOMNode page

@tdd tdd self-assigned this Sep 6, 2023
@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR scope:secondary-pages Part of the desirable pages for shipping translator:seasoned The author of that translation is a seasoned React docs translator labels Sep 6, 2023
@tdd tdd added scope:required-pages Part of the required translations before we can ship and removed scope:secondary-pages Part of the desirable pages for shipping labels Sep 6, 2023
@tdd
Copy link
Collaborator

tdd commented Sep 6, 2023

Merci @emmadal, trop cool. Je regarde ça ASAP.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@emmadal emmadal mentioned this pull request Sep 6, 2023
Open
@emmadal
Copy link
Contributor Author

emmadal commented Sep 6, 2023

Merci @emmadal, trop cool. Je regarde ça ASAP.

super

tdd
tdd requested changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @emmadal !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de continuer à nous filer un coup de main.

Bon c'était assez rapide et ça s'est vu, ça manquait de relecture !

J'ai reformulé quelques trucs au-delà de la typo/ortho, je te laisse voir et appliquer de ton côté, je ferai une repasse visuelle pour finir.

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner. J'y recalerai si besoin les usual suspects : espaces insécables avant les ponctuations doubles, et apostrophes françaises.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans main !

src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/findDOMNode.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Sep 6, 2023
@emmadal
Copy link
Contributor Author

emmadal commented Sep 6, 2023

@tdd je n'arrive pas appliquer tes suggestion en 1 seul commit. ils disent que il y'a plusieurs suggestions sur la meme ligne.

@tdd
Copy link
Collaborator

tdd commented Sep 7, 2023

@emmadal oui j'avais fait un couac à un endroit, j'ai corrigé et intégré du coup.

@emmadal
Copy link
Contributor Author

emmadal commented Sep 7, 2023

@emmadal oui j'avais fait un couac à un endroit, j'ai corrigé et intégré du coup.

D'accord merci bien

@tdd tdd force-pushed the findDOMNode-translation branch from 248c29b to 8801203 Compare September 7, 2023 10:12
@tdd tdd merged commit 2e08226 into reactjs:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdd tdd tdd approved these changes

Assignees

@tdd tdd

Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmadal @tdd