Sync with reactjs.org @ 920f32ec #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Beta] useLayoutEffect API * more * tweak * bla
* [Beta] useEvent -> useEffectEvent * tweak
Proposing a minor grammatical correction on the useEffect API documentation page for triggering an animation example section.
The section under consideration 'Removing unnecessary function dependencies' should use the text 'createOptions function' instead of 'options object' to match the given example correctly. The 'options object' text is being used correctly for the previous section which talks about 'Removing unnecessary object dependencies' however, it must be updated for this section.
The serverUrl variable should be moved inside the component and can be stored as a state to indicate that it's a reactive variable and will be highlighted as such by the linter. Previously the serverUrl variable was stored outside the component function body thus making it a non-reactive value and so it shouldn't have been highlighted by the linter as a useEffect dependency as shown in the concerned example.
* <input> * Fix typo * tweak * separate props * reword * typos * compress * tweaks * Add more * more * shorter * twk * more readable * fix * oops * oops * <textarea> * <progress> * <select>, <progress> * upd * <option> * wip common * wip * more * Fix onSelect desc * index * stub events * events * twk * all events
* Copy over tutorial from old website Fixed up MDX syntax (self-closing `<br>` and `<img>`, and one `style` attribute) * wip * more wip * Move tutorial to be consistent with new beta docs structure * remove HTML comments causing Vercel rendering issues * Fixed all fixme's, minor clarity improvments, updated code links to codesandbox * first half of tutorial re-write draft * Finish tutorial rewrite draft * Fix some formatting issues * Migrate tutorial back to JavaScript to fix Sandpack errors * Fix minor mistakes, formatting, code bugs, clean up images * Fix empty board image size * Fix image size and code highlighting issues * Incorporate feedback from Dan and Sean * edits (wip) * edit * edits * Update beta/src/content/learn/tutorial-tic-tac-toe.md Co-authored-by: Strek <ssharishkumar@gmail.com> * tweak Co-authored-by: Sophie Alpert <git@sophiebits.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Strek <ssharishkumar@gmail.com>
* [Beta] Move Reference before Usage * above -> below
* [Beta] APIs -> Reference * oops
Update referencing-values-with-refs.md
Fix: typo in "Animation Event Handler function" example
* Legacy API, Component: fix href for getDerivedStateFromProps * Legacy API, Component: fix href for getDerivedStateFromProps
* fix: url * fix: check if it works * fix * fix * use legacy link * chore: add to vercel.json
* Fix minor grammar mistakes * Apply suggestions from code review --------- Co-authored-by: Sophie Alpert <git@sophiebits.com>
* Add site config with domain name * Add <meta> tags for languages * Move legacy redirect out of vercel config This lets us give it a more specific subdomain per lang. * Support sites with no legacy * Fix types * Undo unrelated change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 920f32e
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.