-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Reconciliation #262
Conversation
Deploy preview for it-react-org ready! Built with commit 78d4995 |
✔️ Deploy preview for it-reactjs ready! 🔨 Explore the source changes: 78d4995 🔍 Inspect the deploy logs: https://app.netlify.com/sites/it-reactjs/deploys/6005c034e1e34e000844d0e3 😎 Browse the preview: https://deploy-preview-262--it-reactjs.netlify.app |
Any news so far? |
Ciao @mattveraldi! There's a merge conflict, as soon as you fix it I'll review so that we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Co-authored-by: Alessandro De Blasis <alex@deblasis.net>
Thank you 😄 |
Ciao, I finished the issue #71 .
On the "Chiavi" paragraph, I chose to keep using
key
instead of translating it as 'chiave' because, in my opinion, it is more clear for the user that we are specifically referring to the prop itself, not only the concept. Let me know if it is ok for you to keep using 'key'. If that is the case, maybe we could consider to add it in the Glossary. Let me know if I should fix something on the translation or on the sentences and I will do it asap 😄 👍