Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate useDebugValue hook reference #573

Merged
merged 3 commits into from
May 21, 2023

Conversation

seckie
Copy link
Contributor

@seckie seckie commented May 12, 2023

初めてのコントリビューションになります。
Reference > useDebugValue を試しに翻訳してみました。
ChatGPT (GPT-4) での翻訳をベースにして、既存の翻訳や legacy ドキュメントの翻訳の方針に沿って修正をしています。

お役に立てそうでしょうか。ご確認よろしくお願いいたします。

@seckie seckie marked this pull request as ready for review May 12, 2023 15:22
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label May 13, 2023
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

些細な訳語統一やフォーマットの指摘が殆どですが対応をお願いします。

React Dev Tools の inspect は訳すなら「検証」よりは「調査」が良いと思います。そういえば Chrome の開発者ツールもずっと「検証」を使っている気がしますが、個人的にはあれはいつも意味不明だなと思っています…。とはいえ今回は原文併記でカタカナにしておくのが無難な気がしました。

src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
src/content/reference/react/useDebugValue.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label May 13, 2023
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました!
メンテナが 2 人 approve してからマージするルールになっていますのでもう少しお待ちください。

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 初コントリビューションありがとうございます!!!

@koba04 koba04 merged commit 801dc31 into reactjs:main May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants