Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate useExternalStore reference #619

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Conversation

jp-knj
Copy link
Contributor

@jp-knj jp-knj commented Jul 10, 2023

useExternalStore の翻訳です

やったこと

  • ChatGPT Markdown Translator による AI 自動翻訳でテキストを生成
  • 生成されたテキストを自己判断で添削
  • textlint の実行とそれに伴う修正

@jp-knj jp-knj marked this pull request as draft July 10, 2023 14:55
@jp-knj jp-knj marked this pull request as ready for review July 11, 2023 15:08
@jp-knj jp-knj marked this pull request as draft July 11, 2023 15:12
@jp-knj jp-knj marked this pull request as ready for review July 11, 2023 15:26
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューを行いましたので対応をお願いします。

ChatGPT を信用せず、全文丁寧に添削する方向でお願いします。訳抜けやタグ抜け、明らかな誤訳が結構放置されています。またローカルで dev server を立ち上げて、そもそもちゃんとページの表示ができているかの確認をお願いします。

src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
@jp-knj
Copy link
Contributor Author

jp-knj commented Jul 15, 2023

@smikitky
レビューの修正対応しました。

  • dev server を立ち上げして、確認しました。
  • code suggestion を commit と squash して push -f して反映しました。

お手数おかけしますが、再度レビューお願いします。

@github-actions
Copy link

github-actions bot commented Jul 15, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。ほぼ OK なのですが幾つか私の方で見逃しがあったので対応をお願いします:pray:

src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
src/content/reference/react/useSyncExternalStore.md Outdated Show resolved Hide resolved
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
@jp-knj
Copy link
Contributor Author

jp-knj commented Jul 15, 2023

レビュー、ありがとうございます!

71ea816 で code suggestion を squash して push -f して反映しました。

よろしくお願いします🙏

@smikitky
Copy link
Member

ありがとうございました! 2 名が approve してからのマージになりますのでしばらくお待ちください。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ありがとうございます!!!

@koba04 koba04 merged commit 0b9e859 into reactjs:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants