Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "Rules of Hooks" #750

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Translate "Rules of Hooks" #750

merged 2 commits into from
Apr 11, 2024

Conversation

smikitky
Copy link
Member

No description provided.

Copy link

github-actions bot commented Apr 10, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 84.31 KB (🟡 +6 B) 188.23 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけ言い回しの提案をしましたが全体としては LGTM です! 👍

src/content/reference/rules/rules-of-hooks.md Outdated Show resolved Hide resolved
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
legacy-ja-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 5:09pm

@smikitky smikitky merged commit 4890079 into main Apr 11, 2024
3 of 5 checks passed
@smikitky smikitky deleted the tr/rules-of-hooks branch April 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants