Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with react.dev @ 1697ae89 #799

Merged
merged 31 commits into from
Oct 9, 2024
Merged

Sync with react.dev @ 1697ae89 #799

merged 31 commits into from
Oct 9, 2024

Conversation

react-translations-bot
Copy link
Collaborator

@react-translations-bot react-translations-bot commented Oct 7, 2024

This PR was automatically generated.

Merge changes from react.dev at 1697ae8

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

imparth7 and others added 28 commits September 16, 2024 12:36
reactjsday 2024
React conference in Verona, Italy
* Fix typos in thinking-in-react.md

* Update src/content/learn/thinking-in-react.md

---------

Co-authored-by: Ricky <rickhanlonii@gmail.com>
* docs(act.md): correct ReactDOMClient to ReactDOM

* docs(act.md): switch the import to ReactDOMClient instead
Co-authored-by: san.s <san.s@sfeir.com>
* fix: `@testing-library/react-native` links

* Apply suggestions from code review

---------

Co-authored-by: Ricky <rickhanlonii@gmail.com>
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
legacy-ja-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 5:39am

Copy link

github-actions bot commented Oct 7, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.32 KB (🟡 +111 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 106.64 KB (🟡 +57 B) 210.96 KB
/500 106.63 KB (🟡 +57 B) 210.96 KB
/[[...markdownPath]] 108.79 KB (🟡 +57 B) 213.12 KB
/errors 106.85 KB (🟡 +57 B) 211.17 KB
/errors/[errorCode] 106.83 KB (🟡 +57 B) 211.15 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@smikitky
Copy link
Member

smikitky commented Oct 9, 2024

@koba04 こちらよろしくお願いします

毎回名前でメンションした方がよかったでしょうか。

@koba04 koba04 self-requested a review October 9, 2024 13:14
@koba04
Copy link
Member

koba04 commented Oct 9, 2024

@smikitky レビューするので少々お待ちください 🙏

毎回名前でメンションした方がよかったでしょうか。

見落としがちなので、メンションしてもらえると早く対応できると思います 🙏

@koba04 koba04 merged commit afc9a16 into main Oct 9, 2024
5 checks passed
@koba04 koba04 deleted the sync-1697ae89 branch October 9, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.