Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for API-Refernce/React #12

Merged
merged 19 commits into from
Feb 28, 2019

Conversation

cadenzah
Copy link
Contributor

@cadenzah cadenzah commented Feb 9, 2019

Please give me feedbacks, and I will gladly appreciate it and apply your feedbacks! 🙏

Copy link
Contributor Author

@cadenzah cadenzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on phrase extend

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@@ -88,7 +90,7 @@ Suspense lets components "wait" for something before rendering. Today, Suspense

### `React.Component` {#reactcomponent}

`React.Component` is the base class for React components when they are defined using [ES6 classes](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes):
`React.Component`[ES6 class](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes)를 사용하여 React 요소를 정의할 때에 기초가 되는 클래스입니다:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 문장에 나오는 두 개의 class가 다른 의미를 지니는 것도 아닌데 하나는 class로 다른 하나는 클래스로 표현되었습니다. 이유가 있을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taggon ES6 class는 자바스크립트 문법 구문을 강조하는 의미에서 영어로 적었고, 후자의 클래스는 개념적인 의미를 말한다는 점에서 한글로 적었는데, 통일하는 것이 나을까요? 이런 식으로 ES6 class의 형태로 적은 것이 27번째 줄에도 존재합니다.

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
### Hooks {#hooks}

*Hooks* are a new addition in React 16.8. They let you use state and other React features without writing a class. Hooks have a [dedicated docs section](/docs/hooks-intro.html) and a separate API reference:
*Hooks*React 16.8에 새로 추가되었습니다. Hooks를 사용하면 클래스를 사용하지 않아도 상태와 React 기능들을 사용할 수 있도록 해줍니다. Hooks만을 다루는 문서와 API 문서가 존재합니다:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/docs/hooks-intro.html 링크 연결이 실수로 빠진 듯 하네요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞는 지적이십니다. 제가 누락시켰군요. 바로 반영하겠습니다.

Copy link
Contributor Author

@cadenzah cadenzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply and feedback for feedbacks by contributors. Sorry for late change!

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
### Hooks {#hooks}

*Hooks* are a new addition in React 16.8. They let you use state and other React features without writing a class. Hooks have a [dedicated docs section](/docs/hooks-intro.html) and a separate API reference:
*Hooks*React 16.8에 새로 추가되었습니다. Hooks를 사용하면 클래스를 사용하지 않아도 상태와 React 기능들을 사용할 수 있도록 해줍니다. Hooks만을 다루는 문서와 API 문서가 존재합니다:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞는 지적이십니다. 제가 누락시켰군요. 바로 반영하겠습니다.

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@@ -88,7 +90,7 @@ Suspense lets components "wait" for something before rendering. Today, Suspense

### `React.Component` {#reactcomponent}

`React.Component` is the base class for React components when they are defined using [ES6 classes](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes):
`React.Component`[ES6 class](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes)를 사용하여 React 요소를 정의할 때에 기초가 되는 클래스입니다:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taggon ES6 class는 자바스크립트 문법 구문을 강조하는 의미에서 영어로 적었고, 후자의 클래스는 개념적인 의미를 말한다는 점에서 한글로 적었는데, 통일하는 것이 나을까요? 이런 식으로 ES6 class의 형태로 적은 것이 27번째 줄에도 존재합니다.

@taehwanno taehwanno mentioned this pull request Feb 19, 2019
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
- 상태 -> state
- 클래스 -> class
- Link edit (Under directory of /docs)
- 요소, element -> 엘리먼트
- Syntactic Sugar -> 편리한 문법
- Remove of English words originally written on Line 149
- 특성 -> 어트리뷰트
- 고차 컴포넌트 -> Put english word as well
- 코드 스플리팅 -> Code Splitting
- 사용례 -> 사용 사례

- flatten -> Put english word as well
@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit ed0e93a

https://deploy-preview-12--ko-reactjs-org.netlify.com

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@taehwanno
Copy link
Member

netlify 빌드 에러 방지를 위해 모든 링크가 http -> https로 변경되었기에 master를 반영했습니다.

- 클래스 -> class
- `class` -> class
- Error with postposition fixed
- 평평한 -> Put (Flatten) as well
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks 😄

@simsim0709 simsim0709 merged commit db531a8 into reactjs:master Feb 28, 2019
@taehwanno taehwanno mentioned this pull request Mar 3, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants