Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Introducing JSX #18

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Translate Introducing JSX #18

merged 8 commits into from
Apr 19, 2019

Conversation

rkdmen
Copy link
Contributor

@rkdmen rkdmen commented Feb 10, 2019

No description provided.

@tesseralis tesseralis mentioned this pull request Feb 11, 2019
Open
@rkdmen rkdmen changed the title First draft: introducing-jsx Translate Introducing JSX Feb 11, 2019
hg-pyun
hg-pyun requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞춤법이나 틀린 어휘표현이 보입니다. 전체적으로 맞춤법 검사기를 한번 돌려보는게 좋을 것 같습니다.

@rkdmen
Copy link
Contributor Author

rkdmen commented Feb 11, 2019

많이 틀렸네요 ㅎ..검사기 돌려 다 고쳤습니다.

taehwanno
taehwanno reviewed Feb 22, 2019
View reviewed changes
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
@taehwanno
Copy link
Member

upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경되어 직접 충돌 해결했습니다.

@netlify
Copy link

netlify bot commented Feb 23, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit 0696b5b

https://deploy-preview-18--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

@rkdmen 코멘트 피드백 부탁드릴게요 :)

@rkdmen
Copy link
Contributor Author

rkdmen commented Feb 28, 2019

아 네- 제가 아직 확인 못햇어요 요즘 좀일이 바빠져서.. 조만간 확인 할게요-

@gnujoow
Copy link
Member

gnujoow commented Apr 11, 2019

@rkdmen 진행상황을 알 수 있을까요?

@taehwanno taehwanno mentioned this pull request Apr 18, 2019
Closed
@taehwanno
Copy link
Member

3주 이상 응답이 없는 Pull Request에 대해 직접 수정해서 푸쉬하도록 하겠습니다 :)

@taehwanno
Copy link
Member

직접 수정해서 푸쉬해놨습니다.

hg-pyun
hg-pyun approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taehwanno 고생하셨습니다. Approve 하겠습니다 :)

@hg-pyun hg-pyun merged commit 4c798f1 into reactjs:master Apr 19, 2019
@rkdmen rkdmen deleted the introducing-JSX-kor branch August 12, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno taehwanno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkdmen @taehwanno @gnujoow @hg-pyun