Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate forms #30

Merged
merged 12 commits into from
Mar 6, 2019
Merged

Translate forms #30

merged 12 commits into from
Mar 6, 2019

Conversation

hyunalee419
Copy link
Contributor

React Form 페이지 번역했습니다.
피드백 부탁드립니다.

@tesseralis tesseralis mentioned this pull request Feb 16, 2019
Open
BKJang
BKJang reviewed Feb 16, 2019
View reviewed changes
content/docs/forms.md Outdated Show resolved Hide resolved
taehwanno
taehwanno reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백이 늦었네요. 다음부터는 더 빨리 할 수 있도록 노력할게요 :)

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 28, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit e0095a2

https://deploy-preview-30--ko-reactjs-org.netlify.com

@hyunalee419
Copy link
Contributor Author

hyunalee419 commented Mar 1, 2019 •
edited
Loading

@taehwanno 피드백 해주신대로 적용했습니다. 감사합니다 😄

taehwanno
taehwanno reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 피드백 감사합니다. 제가 하나를 빠뜨렸네요.

content/docs/forms.md Outdated Show resolved Hide resolved
taehwanno
taehwanno previously approved these changes Mar 4, 2019
View reviewed changes
taggon
taggon reviewed Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@taggon taggon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

줄 끝에 아마 의도하지 않은 것 같은 탭, 공백 문자가 있는 곳이 몇 군데 눈에 띕니다. 코멘트로는 두 군데만 말씀드렸지만 그 외에도 있으므로 확인해보시고, 의도한 게 아니라면 삭제부탁드립니다.

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@hyunalee419
Copy link
Contributor Author

@taggon 번역하다 실수로 공백이 들어간 것 같습니다. 😅
Files changed 에서 공백이라 생각되는 부분은 모두 처리했습니다. 확인 부탁드립니다~

@simsim0709 simsim0709 self-requested a review March 6, 2019 04:28
simsim0709
simsim0709 approved these changes Mar 6, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709 simsim0709 merged commit c3dd530 into reactjs:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BKJang BKJang BKJang left review comments

@taggon taggon taggon left review comments

@simsim0709 simsim0709 simsim0709 approved these changes

@taehwanno taehwanno taehwanno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hyunalee419 @taggon @taehwanno @simsim0709 @BKJang