-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Invalid Aria Prop #57
Merged
simsim0709
merged 6 commits into
reactjs:master
from
simsim0709:translate-invalid-aria-prop
Mar 8, 2019
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1d79654
Translate Invalid Aria Prop
simsim0709 5a3f827
Apply a review
simsim0709 72b6c97
Fix typo
simsim0709 a050e8e
Merge branch 'master' into translate-invalid-aria-prop
simsim0709 fd7ab03
Fix translation
simsim0709 c0e4900
Merge branch 'master' into translate-invalid-aria-prop
simsim0709 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
접근성에서는 명세 제목을 원문으로 사용했던 데 어느 쪽으로 통일하는 게 좋을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음.. 저도 이 부분은 위키를 보고 번역 한거라 번역하는게 맞는지 원문 그대로 쓰는게 좋은지 정확히 잘 모르겠습니다. 하지만, 번역된 단어
웹 접근성 이니셔티브
도 어색해 보이진 않는거 같습니다. 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taggon 님. 우선 이 부분 원문 사용할지 번역할지는 translate glossary에서 논의하는 걸로 하고, 이 pr은 머지 하겠습니다. 😄