Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Hello world #9

Merged
merged 13 commits into from
Feb 19, 2019
Merged

Translate Hello world #9

merged 13 commits into from
Feb 19, 2019

Conversation

chayeoi
Copy link
Collaborator

@chayeoi chayeoi commented Feb 9, 2019

Added translation to Hello World section.
Please let me know if you find any mistakes.

네비게이션 => 내비게이션
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
@simsim0709 simsim0709 self-requested a review February 9, 2019 15:30
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Show resolved Hide resolved
@taehwanno taehwanno mentioned this pull request Feb 11, 2019

In this guide, we will examine the building blocks of React apps: elements and components. Once you master them, you can create complex apps from small reusable pieces.
이 안내서에서 우리는 엘리먼트와 컴포넌트라고 불리는 React 앱의 구성 블록들에 대해 살펴볼 것입니다. 이들을 숙달하고 나면 재사용 가능한 조각들로부터 복잡한 앱을 만들 수도 있습니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building block 번역에 대한 논의가 필요해보여요. #2 (comment)

content/docs/hello-world.md Outdated Show resolved Hide resolved
@taehwanno
Copy link
Member

@chayeoi 가장 최근에 남긴 리뷰 코멘트에 대한 변경사항이 푸쉬되지 않은거 같아요. 확인 부탁드릴게요 :)

@chayeoi
Copy link
Collaborator Author

chayeoi commented Feb 14, 2019

@taehwanno 푸시를 안 했었네요..! 방금 다시 했습니다 :)

@taehwanno taehwanno merged commit bdb803d into reactjs:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants