-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle internal stylesheets #36
Conversation
Actually, style tags in the body are still broken if they contain quotes. Digging deeper! |
Not sure what's going on here. The test passes, but as seen in this fiddle or when you test this on a real page, the quotes get turned into entities. |
Could you use This opens a security hole though if you ever let user-created content be written inside a |
That works, but is what I had before considered safe? I would think one of the more common use cases of an internal stylesheet would be for custom end-user styles. |
Do you have an example, or is it just a theoretical hole? :) |
That's in reference to react's docs on dangerouslySetInnerHTML but I just did a quick test and |
It's a theoretical hole that I have not proven to be real yet. Since @sickslives tested |
Fixes #35