Adds benchmark option; Adds more tests; #101
Conversation
Adds more tests;
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Travis build is finished and passed... not sure why github isn't reporting that correctly. |
|
👍 |
| time = Benchmark.realtime do | ||
| result = self.render(component, args) | ||
| end | ||
| ::Rails.logger.info "[React::Renderer#render] Rendered #{component} with #{args} (#{(time*1000).round(1)}ms)" |
There was a problem hiding this comment.
maybe a test for this too?
|
I'd prefer if these were done separately since they are quite discrete tasks but meh, this is fine. I think just address the things @vipulnsward said and we can merge this. |
|
I'll try to get to this in the next week or so. |
|
Building a better boat here: https://github.com/pboling/react-rails-benchmark_renderer It requires the ServerRendering refactor, so please release it soon! |
|
Very cool! Glad to see those refactors are paying off. Yes, I want to get a new version out soon, but we're blocked behind rails/sprockets-rails#257 (And I don't have the nerve to dive in and figure it out!) |
• Adds benchmark option
• Adds more tests