Removed unnecessary className on Link #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
| @@ -119,7 +118,7 @@ const Link = React.createClass({ | |||
| if (activeClassName || (activeStyle != null && !isEmptyObject(activeStyle))) { | |||
| if (router.isActive(location, onlyActiveOnIndex)) { | |||
| if (activeClassName) | |||
| props.className += props.className === '' ? activeClassName : ` ${activeClassName}` | |||
| props.className = `${props.className || ''} ${activeClassName}`.trim() | |||
There was a problem hiding this comment.
Is there any harm to just pulling in classnames here? I can't imagine anybody doesn't have classnames already installed, so this should dedupe trivially.
Otherwise IMO this is better written as:
if (activeClassName) {
if (props.className) {
props.className += ` ${activeClassName}`
} else {
props.className = activeClassName
}
}
There was a problem hiding this comment.
Agreed. We can do that after merge. For now, this gets the job done and adds a test so any further fixes are easier.
There was a problem hiding this comment.
I haven't used a className in a while.
|
👍 |
|
LGTM as well, then. Thanks! |
|
I don't use class names in react-boilerplate, I've never had a good use for it. (sorry @JedWatson!) I wouldn't go assuming everybody has it installed! |
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Link />always adds theclass=""attribute even when it's not defined or is active. When you do server rendering you don't want unnecessary attributes.