Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added src folder! #232

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Added src folder! #232

merged 1 commit into from
Mar 23, 2018

Conversation

retyui
Copy link

@retyui retyui commented Feb 25, 2018

I'm working on optimizing the size of the bundle.
And I noticed that in esm build a lot of repetitive code in the components.
Which generates the babel:

function _extends() {/* ... */ }
function _objectWithoutProperties(source, excluded) {/* ... */ }
function _inheritsLoose(subClass, superClass) {/* ... */ }

Babel-runtime takes these repetitive functions to separate modules.
which significantly reduces the size

I'm working on optimizing the size of the bundle.
And I noticed that in esm build a lot of repetitive code in the components.
Which generates the babel:
```js
function _extends() {/* ... */ }
function _objectWithoutProperties(source, excluded) {/* ... */ }
function _inheritsLoose(subClass, superClass) {/* ... */ }
```
Babel-runtime takes these repetitive functions to separate modules.
which significantly reduces the size
@danez
Copy link
Collaborator

danez commented Mar 23, 2018

Thanks, yeah why not :)

@danez danez merged commit a4cc6d0 into reactjs:master Mar 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants