-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add global transition disable switch #506
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default { | ||
disabled: false, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
export { default as CSSTransition } from './CSSTransition'; | ||
export { default as ReplaceTransition } from './ReplaceTransition'; | ||
export { default as TransitionGroup } from './TransitionGroup'; | ||
export { default as Transition } from './Transition'; | ||
export { default as CSSTransition } from './CSSTransition' | ||
export { default as ReplaceTransition } from './ReplaceTransition' | ||
export { default as TransitionGroup } from './TransitionGroup' | ||
export { default as Transition } from './Transition' | ||
export { default as config } from './config' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
import { graphql } from 'gatsby'; | ||
import PropTypes from 'prop-types'; | ||
import React from 'react'; | ||
import { Container } from 'react-bootstrap'; | ||
import Layout from '../components/Layout'; | ||
import Example from '../components/Example'; | ||
|
||
const propTypes = { | ||
location: PropTypes.object.isRequired, | ||
data: PropTypes.shape({ | ||
site: PropTypes.shape({ | ||
siteMetadata: PropTypes.shape({ | ||
componentPages: PropTypes.arrayOf( | ||
PropTypes.shape({ | ||
path: PropTypes.string.isRequired, | ||
displayName: PropTypes.string.isRequired, | ||
}) | ||
).isRequired, | ||
}).isRequired, | ||
}).isRequired, | ||
}).isRequired, | ||
}; | ||
|
||
const Testing = ({ data, location }) => ( | ||
<Layout data={data} location={location}> | ||
<Container> | ||
<h1>Testing Components with Transitions</h1> | ||
<p> | ||
In some situations, like visual snapshot testing, it's helpful to | ||
disable transitions so they don't complicate the test, or introduce | ||
abitrary waits. To make this easier <code>react-transition-group</code>{' '} | ||
exposes a way to globally toggle transitions. When set,{' '} | ||
<strong>all</strong> transitions, when toggled, will immediately switch | ||
to their entered or exited states as appropriate. | ||
</p> | ||
<pre className="language-js"> | ||
<code> | ||
{` | ||
import { config } from 'react-transition-group | ||
|
||
config.disabled = true | ||
`.trim()} | ||
</code> | ||
</pre> | ||
<blockquote> | ||
<p> | ||
<b>Note</b>: This <strong>does not</strong> automatically disable | ||
animations. It only disabled waits in <code>Transition</code>. You may | ||
also have to disable animation as appropriate for the library. | ||
example:{' '} | ||
<a href="http://velocityjs.org/#mock">Mocking in Velocity.js</a> | ||
</p> | ||
</blockquote> | ||
</Container> | ||
</Layout> | ||
); | ||
|
||
Testing.propTypes = propTypes; | ||
|
||
export default Testing; | ||
|
||
export const pageQuery = graphql` | ||
query TestingQuery { | ||
site { | ||
...Layout_site | ||
} | ||
} | ||
`; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need all this 🤨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't i just copy/pasted from the other page