-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enter animations with mountOnEnter or unmountOnExit #749
fix: enter animations with mountOnEnter or unmountOnExit #749
Conversation
I've added more stories for CSSTransition and it seems to work fine. |
This introduces an additional render because |
Hi @koba04. Thanks again for working on this pull request to fix the bug that I reported. Is there perhaps a timeline to when this pull request will be merged into the main branch? |
@anatolzak |
Hi, any update on that ? I'm really interested in that fix |
I'll check it again. |
16f548d
to
5478f34
Compare
5478f34
to
42616bd
Compare
I've reworked this to get merged and requested reviewing. |
Hi again, thanks for working on this ! |
@eps1lon Could you review this PR? |
Hi guys I am also pretty interested in this fix - so would be amazing if it can be moved further :) |
I think I had enough time to get feedback, so I'll merge this. |
## [4.4.3](v4.4.2...v4.4.3) (2022-07-30) ### Bug Fixes * enter animations with mountOnEnter or unmountOnExit ([#749](#749)) ([51bdceb](51bdceb))
🎉 This PR is included in version 4.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30) ### Bug Fixes * enter animations with mountOnEnter or unmountOnExit ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30) ### Bug Fixes * enter animations with mountOnEnter or unmountOnExit ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30) ### Bug Fixes * enter animations with mountOnEnter or unmountOnExit ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30) ### Bug Fixes * enter animations with mountOnEnter or unmountOnExit ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
fixes #745
This fixes enter animations with
mountOnEnter
orunmounOnExit
. However, this might introduce other issues like unexpected animations, so I have to test this before this gets merged.