-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /link redirects #6670
Add /link redirects #6670
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicked through all the links printed by cat vercel.json | jq -r '.redirects[] | "source: " + .source + ", destination: " + (if .destination | startswith("https") then .destination else "https://react.dev" + .destination end)'
/link/event-pooling
-> /reference/react/useEffect#fetching-data-with-effects
seems off. The rest looks good.
vercel.json
Outdated
}, | ||
{ | ||
"source": "/link/event-pooling", | ||
"destination": "/reference/react/useEffect#fetching-data-with-effects", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems off since we link it from
"This synthetic event is reused for performance reasons. If you're seeing this, " +
"you're %s `%s` on a released/nullified synthetic event. %s. " +
'If you must keep the original synthetic event around, use event.persist(). ' +
'See https://react.dev/link/event-pooling for more information.',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, this must be an existing mistake from here: https://github.com/reactjs/legacy.reactjs.org/blob/main/vercel.json#L266
I'll update to the old event pooling docs
Depends on reactjs/react.dev#6670 [merged]
Depends on reactjs/react.dev#6670 [merged] DiffTrain build for [1940cb2](1940cb2)
Depends on reactjs/react.dev#6670 [merged]
Adds /link redirects so the reactjs.org URLs in warning messages can be changed to react.dev.