Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): add react without es6 translate #128

Merged
merged 10 commits into from
Feb 28, 2019

Conversation

zhaozhiming
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for cn-reactjs ready!

Built with commit a88d17a

https://deploy-preview-128--cn-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for zh-hans-reactjs ready!

Built with commit a88d17a

https://deploy-preview-128--zh-hans-reactjs.netlify.com

@zhaozhiming zhaozhiming mentioned this pull request Feb 22, 2019
@QC-L QC-L added the Pending Review 已翻译,待校对阶段 label Feb 22, 2019
Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些细节需要再斟酌修改下。

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@hijiangtao hijiangtao self-requested a review February 23, 2019 16:24
@hijiangtao hijiangtao added Pending Modify 已校对,待修改阶段 and removed Pending Review 已翻译,待校对阶段 labels Feb 24, 2019
@zhaozhiming
Copy link
Contributor Author

@hijiangtao @chenshuai2144 改的差不多了,请两位有空再review下,谢谢

@hijiangtao hijiangtao added Pending Re-Review 已修改,待审校阶段 and removed Pending Modify 已校对,待修改阶段 labels Feb 27, 2019
hijiangtao
hijiangtao previously approved these changes Feb 27, 2019
Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hijiangtao
Copy link
Member

@zhaozhiming 我先 approve 了,没有 resolve 的几个地方给了些建议你可以看看,另外还有一句翻译我让 @QC-L 等会给出建议。再来一位 reviewer 通过可以 merge。

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@zhaozhiming
Copy link
Contributor Author

@hijiangtao @QC-L @chenshuai2144 好的,review意见已经修改,请再看看有没有问题,谢谢

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@hijiangtao hijiangtao merged commit 6ed71bb into reactjs:master Feb 28, 2019
OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Re-Review 已修改,待审校阶段
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants