Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): translate content/docs/faq-styling.md into Chinese #134

Merged
merged 9 commits into from
Apr 1, 2019

Conversation

infinnie
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for cn-reactjs ready!

Built with commit 9697436

https://deploy-preview-134--cn-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for zh-hans-reactjs ready!

Built with commit 9697436

https://deploy-preview-134--zh-hans-reactjs.netlify.com

@infinnie infinnie mentioned this pull request Feb 25, 2019
@QC-L QC-L added the Pending Review 已翻译,待校对阶段 label Feb 25, 2019
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
LeoEatle and others added 2 commits March 6, 2019 18:00
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
@LeoEatle LeoEatle added Pending Modify 已校对,待修改阶段 and removed Pending Review 已翻译,待校对阶段 labels Mar 29, 2019
@LeoEatle
Copy link
Collaborator

不好意思,这个 PR 拖的有点久,但是有些部分还是改一下 @infinnie

LeoEatle and others added 4 commits March 30, 2019 09:03
@QC-L QC-L changed the title Translate: FAQ\Styling and CSS #4 docs(cn): translate content/docs/faq-styling.md into Chinese Apr 1, 2019

### Are inline styles bad? {#are-inline-styles-bad}
### 行内样式不好 (bad) 吗? {#are-inline-styles-bad}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥 bad 也括号一下?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 行内样式不好 (bad) 吗? {#are-inline-styles-bad}
### 内联样式不好吗? {#are-inline-styles-bad}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad 不是你们推荐保留原文的么?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前不翻译的场景是在注释中,单独的一个 Bad!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里倒也无伤大雅,所以我当时就没有修改


CSS classes are generally better for performance than inline styles.
从性能角度来说,CSS 的 class 通常比行内样式更好。
Copy link
Member

@yuqingc yuqingc Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看到的文档把 inline style 翻译成“内联样式的比较多”

@QC-L QC-L merged commit 0a15592 into reactjs:master Apr 1, 2019
@QC-L
Copy link
Member

QC-L commented Apr 1, 2019

@infinnie 拖的时间有点久,Sorry!感谢提交!后面会有译者墙,请期待。

OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
…#134)

* Translate: FAQ\Styling and CSS reactjs#4

* Update faq-styling.md

* Update content/docs/faq-styling.md

Co-Authored-By: infinnie <w4ergf@qq.com>

* Update faq-styling.md

* Update content/docs/faq-styling.md

Co-Authored-By: infinnie <w4ergf@qq.com>

* Update content/docs/faq-styling.md

Co-Authored-By: infinnie <w4ergf@qq.com>

* Update faq-styling.md

* Update faq-styling.md

* Update faq-styling.md
@fonkie fonkie requested a review from jothy1023 May 10, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Modify 已校对,待修改阶段
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants