Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): add Thinking in React translations #8

Merged
merged 7 commits into from
Feb 5, 2019
Merged

docs(cn): add Thinking in React translations #8

merged 7 commits into from
Feb 5, 2019

Conversation

robertying
Copy link
Collaborator

Retranslate the whole doc with limited reference to the old one. Phrasing style can be a lot different.

Open to suggestions. 🙂

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@robertying
Copy link
Collaborator Author

I'll wait for all the reviews to be finished before submitting a new commit.

Copy link
Member

@yuqingc yuqingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Member

@QC-L QC-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档翻译应遵循原文、保证用词准确。较多延展的地方不应由译者加上,而是留给读者思考。需要做些修改。

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@hijiangtao
Copy link
Member

此 PR 建议再审校一遍。

@robertying
Copy link
Collaborator Author

感谢建议!

但是个人认为:对于不涉及到具体使用的文档部分,只需要表达意思顺畅,能有效反映上下文内容即可。不应拘泥于原文,并期望与其保持严格的语句对应。否则就会像是在用中文写英文,失去了翻译的意义。

如:
You'll see here that we have five components in our simple app.
翻译为
你会看到……
就更像是在说英文。

@hijiangtao
Copy link
Member

我在这句话加上标注的原因有两个:

  • 译文「下面是一个有着五个组件的简单应用。」在表述上存在误解,例如上下文环境并不包括「下面」
  • 「一个有着五个组件的简单应用」读上去是拗口的,在语序上「简单应用中包含五个组件」更顺畅

Copy link
Member

@dear-lizhihua dear-lizhihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些建议,明天继续

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@robertying
Copy link
Collaborator Author

已更新 commit,解决了大部分 review 的反馈。请大家继续审阅。

@robertying
Copy link
Collaborator Author

md 源文件似乎存在编码问题,可能是 Mac 下的键盘导致的,使得预览结果在 GitHub 上出现问号。我之后会处理。

@QC-L
Copy link
Member

QC-L commented Feb 2, 2019

@robertying 用的什么工具?是不是 VSCode?

@robertying
Copy link
Collaborator Author

robertying commented Feb 2, 2019

VSCode。之前在一个 commit message 上就出现过问号,所以应该不是文件编码问题,怀疑是中文键盘在一些情况下会添加奇怪的东西。不过 commit 也是用 VSCode 提的。

相关 issue:microsoft/vscode#37114

@QC-L
Copy link
Member

QC-L commented Feb 2, 2019

@robertying 建议 md 文件使用其他的,我用 VSCode 也出现过相同的问题。不知道是不是插件的问题。

Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dear-lizhihua 给的建议再修改下,可以合进主干。

@robertying
Copy link
Collaborator Author

@hijiangtao 已经按照给出的建议修改,等 @dear-lizhihua 的后半部分 review。

Copy link
Member

@dear-lizhihua dear-lizhihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 2 校对

content/docs/thinking-in-react.md Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Member

@dear-lizhihua dear-lizhihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 3 的一些建议

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Member

@dear-lizhihua dear-lizhihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 4-5 的一些建议

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@QC-L QC-L merged commit 1b60c35 into reactjs:cn Feb 5, 2019
QC-L pushed a commit that referenced this pull request Feb 5, 2019
* docs(cn): add `Thinking in React` translations

* docs(cn): add translation for `mock`

* docs(cn): modify phrasing in regard to review suggestions

* docs(cn): changes regarding review feedback

* docs(cn): rephrase some words & remove control characters

* docs(cn): revert Wikipedia links to English version

* docs(cn): changes for overall smoothness
@robertying robertying deleted the cn-robert branch February 5, 2019 13:59
@QC-L QC-L mentioned this pull request Feb 14, 2019
OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
* docs(cn): add `Thinking in React` translations

* docs(cn): add translation for `mock`

* docs(cn): modify phrasing in regard to review suggestions

* docs(cn): changes regarding review feedback

* docs(cn): rephrase some words & remove control characters

* docs(cn): revert Wikipedia links to English version

* docs(cn): changes for overall smoothness
@civet
Copy link

civet commented Oct 12, 2019

Thinking in React 翻译成 “React编程思想” 可能会更通俗一点(参考那些 Thinking in Java, C++ 的书名译法)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants